fix: enhance Dockerfile for multi-platform builds #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the support building for multiple platforms Dockerfile.
- Removed explicit platform from base image, using `${BUILDPLATFORM}` instead.
- Added `TARGETPLATFORM`, `BUILDPLATFORM`, `TARGETOS`, and `TARGETARCH` arguments for clarity and flexibility.
- Ensures consistent platform handling throughout the build process.
Fixes: angelnu#299
|
Thanks for the pr. Merging so we can test the ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR improves the support for building multiple platforms Dockerfile.
${BUILDPLATFORM}instead.TARGETPLATFORM,BUILDPLATFORM,TARGETOS, andTARGETARCHarguments for clarity and flexibility.Benefits
Multi arch builds are working again.
Possible drawbacks
Applicable issues
Additional information
Running from my raspberry pi:
$ docker container run -ti --rm gateway-admision-controller Loaded image: gateway-admision-controller:latest {"addr":":8080","app":"gateway-admision-controller","http-server":"webhooks","level":"info","lib":"kubewebhook","msg":"Command config is config.CmdConfig{Debug:false, Development:false, SetGatewayDefault:false, WebhookListenAddr:\":8080\", MetricsListenAddr:\"\", MetricsPath:\"\", TLSCertFilePath:\"\", TLSKeyFilePath:\"\", Gateway:\"\", D NS:\"\", DNSPolicy:\"\", SetGatewayLabel:\"\", SetGatewayLabelValue:\"\", SetGatewayAnnotation:\"\", SetGatewayAnnotationValue:\"\", InitImage:\"\", InitImagePullPol:\"\", InitCmd:\"\", InitMountPoint:\"\", SidecarImage:\"\", SidecarImagePullPol:\"\", SidecarCmd:\"\", SidecarMountPoint:\"\", SidecarAsInit:false, ConfigmapName:\"\"}","serv ice":"webhook-handler","time":"2025-05-07T15:11:32Z","version":"dev","webhook":"gatewayPodMutator"} {"addr":":8080","app":"gateway-admision-controller","http-server":"webhooks","level":"info","lib":"kubewebhook","msg":"Current DNS config is resolv.Resolver{Domains:[]string{}, Nameservers:[]string{\"192.168.100.1\"}, Search:[]string{\"lan\"}, Sortlist:[]string{}, Options:[]resolv.ResolverOption{}}","service":"webhook-handler","time":"202 5-05-07T15:11:32Z","version":"dev","webhook":"gatewayPodMutator"} {"addr":":8080","app":"gateway-admision-controller","http-server":"webhooks","level":"warning","msg":"webhook running without TLS","time":"2025-05-07T15:11:32Z","version":"dev"} {"addr":":8080","app":"gateway-admision-controller","http-server":"webhooks","level":"info","msg":"http server listening...","time":"2025-05-07T15:11:32Z","version":"dev"} ^C{"app":"gateway-admision-controller","level":"info","msg":"signal interrupt received","time":"2025-05-07T15:11:33Z","version":"dev"} {"addr":":8080","app":"gateway-admision-controller","http-server":"webhooks","level":"info","msg":"start draining connections","time":"2025-05-07T15:11:33Z","version":"dev"} {"addr":":8080","app":"gateway-admision-controller","http-server":"webhooks","level":"info","msg":"server stopped","time":"2025-05-07T15:11:33Z","version":"dev"}