feat: Add X86_16 platform support #4683
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xor2003 would you be able to add a testcase to the decompiler; something like this: angr/tests/analyses/decompiler/test_decompiler.py Line 3486 in c3948ca Ideally, just a minimal test to verify that the decompiler is producing code on a 16 bit binary. You can add a binary for the test to the binaries repo in a PR, link the issue in your top comment for this PR, and it should run in CI. |
8000
for more information, see https://pre-commit.ci
mborgerson
reviewed
Jun 13, 2024
| @@ -529,8 +529,15 @@ def _handle_Const(self, expr) -> MultiValues: | |||
| return MultiValues(clrp) | |||
|
|
|||
| def _handle_Conversion(self, expr): | |||
| simop = vex_operations[expr.op] | |||
| bits = int(simop.op_attrs["to_size"]) | |||
| if expr.op == "Iop_1Uto16": | |||
There was a problem hiding this comment.
Where are these Iop_* defined?
There was a problem hiding this comment.
Co-authored-by: Joris van Eijden <joris.vaneijden@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch required for the following X86 16 bit platform to work. See PR:
angr/angr-platforms#70
Decompiler generates some output.