8000 Phoenix: Remove a memo-based hack in short-circuit matching. by ltfish · Pull Request #5521 · angr/angr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Phoenix: Remove a memo-based hack in short-circuit matching. #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

ltfish
Copy link
Member
@ltfish ltfish commented Jun 12, 2025

This hack was causing the loss of legitimate variable assignments in converted conditional jump expressions when MultiStatementExpression is involved; This is because convert_claripy_bool_ast may not pick up the expression in the memo dict if the expression is simplified by claripy. An example is A and B && C, when calling convert_claripy_bool_ast on A && B && C, we will never see B && C as a subexpression.

@ltfish ltfish self-assigned this Jun 12, 2025
@ltfish ltfish added bug Something is broken enhancement Some subsystem of angr needs tweaking labels Jun 12, 2025
@rhelmot
Copy link
Member
rhelmot commented Jun 12, 2025

Corpus decompilation diffs can be found at angr/dec-snapshots@master...angr/angr_5521

@ltfish ltfish force-pushed the fix/phoenix_acyclic_short_circuit_no_memo branch from 433b745 to 9fd659f Compare June 12, 2025 04:05
@ltfish ltfish merged commit 23c630b into master Jun 12, 2025
22 of 23 checks passed
@ltfish ltfish deleted the fix/phoenix_acyclic_short_circuit_no_memo branch June 12, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken enhancement Some subsystem of angr needs tweaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0