Phoenix: Remove a memo-based hack in short-circuit matching. #5521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack was causing the loss of legitimate variable assignments in converted conditional jump expressions when
MultiStatementExpression
is involved; This is becauseconvert_claripy_bool_ast
may not pick up the expression in the memo dict if the expression is simplified by claripy. An example isA
andB && C
, when callingconvert_claripy_bool_ast
onA && B && C
, we will never seeB && C
as a subexpression.