Corpus Testing Bugfixes #5085
Open
Corpus Testing Bugfixes #5085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've introduced a timeout to the analyze_binaries job to prevent the accidental overuse of GitHub Actions minutes in the future. The retries variable was missing and so the number of retries was empty and never being evaluated. Lastly, we update the gh_push_file.sh script to be smarter about retriable conditions.
…EN env var convention
…ter-timeouts
|
Thank you!
Do you think hosting the content elsewhere (e.g., an HTTP server that we control) is a better solution? |
Yeah, I think that could work. You really just need to be able to push/pull the snapshots from somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several bugs are addressed in the corpus testing framework.
gh_push_file.shto determine what errors can be safely recovered from short-circuiting otherwisetimeou 8000 t-minutessetting (30 minutes at most per file) to theanalyze_binariesjob$ANALYZE_SNAPSHOT_RETRIESvariable that was causing the[: 12: unary operator expectederrorTEMP_DIRtoSNAPSHOT_DIRinsnapshot_diff.shgh_ls.shscript was mistakenly being called to enumerate files in the master/main branch due to a missing-b ${REF_HEAD}option that has now been added. There shouldn’t be any more file discrepancies within the snapshot branchGH_TOKENoverGITHUB_TOKENis being appliedactionlint,action-validator,shellcheck,shfmtItems that remain to be addressed: