8000 fix(material/autocomplete): error if keydown is dispatched too early by crisbeto · Pull Request #22513 · angular/components · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(material/autocomplete): error if keydown is dispatched too early #22513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2021
Merged

fix(material/autocomplete): error if keydown is dispatched too early #22513

merged 1 commit into from
Apr 21, 2021

Conversation

crisbeto
Copy link
Member

Fixes an error that is thrown if a keydown event is dispatched before the autocomplete panel has been initialized.

Fixes #22511.

@crisbeto
fix(material/autocomplete): error if keydown is dispatched too early
9a6253e 
Fixes an error that is thrown if a `keydown` event is dispatched before the autocomplete panel has been initialized.

Fixes angular#22511.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 19, 2021
@crisbeto crisbeto requested a review from jelbourn April 19, 2021 20:48
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 19, 2021
jelbourn
jelbourn approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member
@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 20, 2021
@wagnermaciel wagnermaciel merged commit 0fbd3e7 into angular:master Apr 21, 2021
wagnermaciel pushed a commit that referenced this pull request Apr 21, 2021
@crisbeto @wagnermaciel
fix(material/autocomplete): error if keydown is dispatched too early (#…
da92944 
…22513)

Fixes an error that is thrown if a `keydown` event is dispatched before the autocomplete panel has been initialized.

Fixes #22511.

(cherry picked from commit 0fbd3e7)
wagnermaciel pushed a commit that referenced this pull request Apr 21, 2021
@crisbeto @wagnermaciel
fix(material/autocomplete): error if keydown is dispatched too early (#…
9e68bf8 
…22513)

Fixes an error that is thrown if a `keydown` event is dispatched before the autocomplete panel has been initialized.

Fixes #22511.

(cherry picked from commit 0fbd3e7)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Mileston 4661 e
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatAutocomplete): cannot read property 'nativeElement' of undefined
3 participants
@crisbeto @jelbourn @wagnermaciel
0