8000 Support custom output path for test command by JonCubed · Pull Request #681 · angular/angular-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support custom output path for test command #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Support custom output path for test command #681

wants to merge 5 commits into from

Conversation

JonCubed
Copy link
Contributor
@JonCubed JonCubed commented May 8, 2016 •
edited
Loading

Proposed changes for #682

JonCubed added 2 commits May 8, 2016 22:43
@JonCubed
Support custom output path for test command
8185984 
Added output-path flag and reading outputPath default value from angular-cli.json to support custom output paths for test command
@JonCubed
Add outputPath to defaults
5f72fcf
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@JonCubed JonCubed mentioned this pull request May 8, 2016
Closed
@googlebot
Copy link

CLAs look good, thanks!

JonCubed added 2 commits May 8, 2016 23:42
@JonCubed
Update test.js
44b5481 
Handle case when ngConfig is null or undefined
@JonCubed
Merge branch 'master' into patch-1
c2aad84
@hansl
Copy link
Contributor
hansl commented May 11, 2016

This will not work with ng build and ng serve. What's the problem you're trying to solve?

If it's the implementation of an outputPath, I'd say you'd need to fix build and serve, not test, since test already uses serve.

@JonCubed
Copy link
Contributor Author
JonCubed commented May 11, 2016 •
edited
Loading

The major issue i'm having is the output path in test is hard coded to dist/, I'm using Visual Studio and ASP.NET Core which uses wwwroot/ as its public folder and I would like for ng test to use that folder instead. I can already tell ng build to output there and ng serve to serve from there using .ember-cli.

I'm happy to attempt an angular2 add-on for the build and serve command that reads its output path from angular-cli.json instead of .ember-cli and forwards the command options to defaults command in ember. Having to set it in one place is better.

@hansl
Copy link
Contributor
hansl commented May 13, 2016

This PR is not the proper solution. Removing as we're going to fix the issue another way, for both ng build, ng test and ng serve.

@hansl hansl closed this May 13, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonCubed @googlebot @hansl
0