8000 fix(template): add missing parameter to protractor by shouichi · Pull Request #1011 · angular/angular-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(template): add missing parameter to protractor #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(template): add missing parameter to protractor #1011

wants to merge 1 commit into from

Conversation

shouichi
Copy link
@shouichi shouichi commented Jun 4, 2016

Config file path parameter to protractor is missing in the generated
package.json which leads to failure of npm run e2e. Fix template to add
one.

@shouichi
fix(template): add missing parameter to protractor
fb8da1a 
Config file path parameter to protractor is missing in the generated
package.json which leads to failure of npm run e2e. Fix template to add
one.
@filipesilva
Copy link
Contributor
filipesilva commented Jun 6, 2016 •
edited
Loading

This change unfortunately breaks ng e2e with the error Error: more than one config file specified.

This is because addon/ng2/tasks/e2e.ts already sends in the config file as an argument resulting in two configs total in the npm script. That config file is part of the following entry in angular-cli.json of the generated project:

  "e2e": {
    "protractor": {
      "config": "config/protractor.conf.js"
    }
  },

Meanwhile the best I can say is that you can run npm run e2e -- config/protractor.conf.js to use the npm script manually.

@filipesilva filipesilva closed this Jun 6, 2016
@shouichi shouichi deleted the hotfix/e2e branch June 6, 2016 02:07
@shouichi
Copy link
Author
shouichi commented Jun 6, 2016

Meanwhile the best I can say is that you can run npm run e2e -- config/protractor.conf.js to use the npm script manually.

I see. Thanks!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shouichi @filipesilva
0