8000 fix(@angular/core): mark `zone.js` as an optional peer dependency by alan-agius4 · Pull Request #61616 · angular/angular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(@angular/core): mark zone.js as an optional peer dependency #61616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(@angular/core): mark zone.js as an optional peer dependency #61616

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

zone.js is no longer mandatory.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 22, 2025
@pullapprove pullapprove bot requested a review from crisbeto May 22, 2025 16:13
@alan-agius4 alan-agius4 changed the title fix(@angular/core): zone.js should be an optional peer dependency fix(@angular/core): mark zone.js as an optional peer dependency May 22, 2025
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2025
@alan-agius4 alan-agius4 removed the request for review from crisbeto May 22, 2025 16:24
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 22, 2025
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label May 22, 2025
@ngbot ngbot bot added this to the Backlog milestone May 22, 2025
@alan-agius4 alan-agius4 added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 22, 2025
@alan-agius4
Copy link
Contributor Author

caretaker note: this change does not effect G3.

@Martinspire
Copy link

Quick question: won't this break backwards compatibility with old projects that don't have ZoneJS in their dependency list, since Angular 2+ would automatically grab it?

@alan-agius4
Copy link
Contributor Author
alan-agius4 commented May 22, 2025 •
edited
Loading

npm (v7+) and pnpm (v7+) support auto-installing peer dependencies, including those explicitly marked as optional so that should not be a problem.

Although in general, it would be recommended to have a stricter dependency policy and avoid auto-installing peer dependency and have them explicitly listed.

atscott pushed a commit that referenced this pull request May 22, 2025
@alan-agius4 @atscott
fix(core): mark zone.js as an optional peer dependency (#61616)
c895115 
`zone.js` is no longer mandatory.

PR Close #61616
@atscott
Copy link
Contributor
atscott commented May 22, 2025

This PR was merged into the repository by commit 229cdde.

The changes were merged into the following branches: main, 20.0.x

@atscott atscott closed this in 229cdde May 22, 2025
@alan-agius4 alan-agius4 deleted the optional-zone.js branch May 22, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
36C7
3 participants
@alan-agius4 @Martinspire @atscott
0