8000 [20.1.x] Refactor macro/rule imports in devtools and adev by josephperrott · Pull Request #62629 · angular/angular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[20.1.x] Refactor macro/rule imports in devtools and adev #62629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[20.1.x] Refactor macro/rule imports in devtools and adev #62629

wants to merge 2 commits into from

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott requested a review from devversion July 14, 2025 15:14
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Jul 14, 2025
@ngbot ngbot bot modified the milestone: Backlog Jul 14, 2025
@josephperrott josephperrott force-pushed the correct-tsconfigs-patch branch 2 times, most recently from 3d95667 to 2d7c75a Compare July 14, 2025 22:05
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 14, 2025
@josephperrott josephperrott force-pushed the correct-tsconfigs-patch branch from 2d7c75a to 34fc3a7 Compare July 15, 2025 00:30
@josephperrott josephperrott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 15, 2025
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 15, 2025
@AndrewKushnir
Copy link
Contributor

Adding the cleanup label since there are a couple of files that can't be merged due to conflicts.

@josephperrott
build: move all rule/macro loading into devtools/defaults.bzl
2a90e08 
Move all of our loading into a local defaults.bzl file instead of mixed loading via tools/defaults and devtolls/defaults
@josephperrott
build: move all rule/macro loading into adev/defaults.bzl and fix int…
548b7c0 
…ellisense loading

Move all of our loading into a local defaults.bzl file instead of mixed loading via tools/defaults and adev/defaults
@josephperrott josephperrott force-pushed the correct-tsconfigs-patch branch from 34fc3a7 to 548b7c0 Compare July 16, 2025 17:16
@josephperrott josephperrott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 16, 2025
@kirjs
Copy link
Contributor
kirjs commented Jul 16, 2025

This PR was merged into the repository by commit 2bcdc66.

The changes were merged into the following branches: 20.1.x

kirjs pushed a commit that referenced this pull request Jul 16, 2025
@josephperrott @NothingEverHappens
build: move all rule/macro loading into devtools/defaults.bzl (#62629)
7bf66f0 
Move all of our loading into a local defaults.bzl file instead of mixed loading via tools/defaults and devtolls/defaults

PR Close #62629
kirjs pushed a commit that referenced this pull request Jul 16, 2025
@josephperrott @NothingEverHappens
build: move all rule/macro loading into adev/defaults.bzl and fix int…
2bcdc66 
…ellisense loading (#62629)

Move all of our loading into a local defaults.bzl file instead of mixed loading via tools/defaults and adev/defaults

PR Close #62629
@kirjs kirjs closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @AndrewKushnir @kirjs @devversion
0