8000 Integrate all by Garcia6l20 · Pull Request #3 · andreasbuhr/cppcoro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Integrate a 8000 ll #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Garcia6l20
Copy link

Fixes clang build on github workflow

  • add -lc++ to CMAKE_EXE_LINKER_FLAGS
  • remove workaround in FindCppcoroCoroutine.cmake
  • add noexcept specifier required by clang-12

Garcia6l20 and others added 2 commits October 12, 2020 09:44
- removing libc++ workaround (should be qualified correctly)
@Garcia6l20
Copy link
Author

@andreasbuhr
Copy link
Owner

Thank you so much for your work @Garcia6l20 , this is great.

The integrate_all branch here has the purpose to test whether everything combined works as expected. But because everything is mixed in integrate_all, we cannot create nice pull requests for Lewis Baker from integrate_all. Could you please create pull requests towards the topic branches?

So the changes in .github/workflows/cmake.yml should go into https://github.com/andreasbuhr/cppcoro/tree/add_github_actions

The changes in cmake/FindCppcoroCoroutines.cmake should go into https://github.com/andreasbuhr/cppcoro/tree/add_cmake_support

And the changes in include/cppcoro/generator.hpp are not needed any more, as Lewis just merged lewissbaker#156 . I will merge it into the branches on andreasbuhr/cppcoro soon.

@Garcia6l20
Copy link
Author

Yes I will, thanks to you for managing all of this !
However I'm a bit scared that I'll not be able to propose the io_ring version with github actions working.
Ubuntu's kenel is < 5.6 so IO operation will not work.
I also tried to use a workflow based on containers but it looks like io_ring operations result in Operation not permitted on docker.

Do you know If someone succeeded in IO implementation using something more usual that io_ring ? Maybe epoll ?

@Garcia6l20 Garcia6l20 closed this Oct 12, 2020
@andreasbuhr
Copy link
Owner

Thanks for bringing my attention to the problem of testing an io_uring backend on Ubuntu. I was not aware of that problem. There is this epoll-backend which we could brush up for a new pull request: lewissbaker#64. Still, it would be nice to have support for both backends in cppcoro.

@andreasbuhr
Copy link
Owner

I just installed Ubuntu 20.10 beta. It has the 5.8.0 kernel. So as soon as Ubuntu 20.10 is widely available, there is a platform for testing. Unfortunately, Ubuntu 20.10 is not an LTS, so let's see whether we'll get it in Github Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0