Replace custom linked list with a queue and refcount #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the custom linked list implementation with a queue-based solution that includes reference counting, simplifying element management. Key changes include:
- Converting linked list operations in ElementList to use a Deque for queuing elements.
- Removing the TailElement, HeadElement, and ElementBase classes.
- Updating element ownership handling and reference counting in Element and InnerArc.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/test/java/eu/aylett/arc/ArcTest.java | Updated semaphore synchronization in the concurrent test. |
| lib/src/main/java/eu/aylett/arc/internal/TailElement.java | Removed obsolete linked list tail implementation. |
| lib/src/main/java/eu/aylett/arc/internal/InnerArc.java | Updated owner retrieval and switch-expression logic. |
| lib/src/main/java/eu/aylett/arc/internal/HeadElement.java | Removed obsolete linked list head implementation. |
| lib/src/main/java/eu/aylett/arc/internal/ElementList.java | Replaced linked list operations with a queue and introduced refcount-based methods. |
| lib/src/main/java/eu/aylett/arc/internal/ElementBase.java | Removed obsolete interface. |
| lib/src/main/java/eu/aylett/arc/internal/Element.java | Updated to manage element ownership and reference counting. |
| config/checkstyle/checkstyle.xml | Removed the Indentation module and related suppression settings. |
Comments suppressed due to low confidence (2)
lib/src/test/java/eu/aylett/arc/ArcTest.java:186
- Changing from inOneSem.release() to inOneSem.acquire() could block the test unexpectedly. Please confirm that this alteration is intentional and that the test is updated accordingly.
inOneSem.acquire();
lib/src/main/java/eu/aylett/arc/internal/ElementList.java:133
- The method bringToHead() receives the parameter 'element', yet it uses 'newElement' when calling addRef(). This appears to be an incorrect variable reference and should be corrected to use 'element'.
var newlyAdded = newElement.addRef(this);
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.