Remove remaining warning suppression #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid some checkstyle warnings by fixing guard annotations * Avoid spotbugs warnings by only passing in what we need
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes remaining warning suppressions and refines how lock and nullness annotations are applied, while abstracting thread‐pool usage in Element.
- Replaced suppressed warnings by adding Checker Framework lock annotations.
- Updated
ElementandArcto accept a generic pool function instead of a rawForkJoinPool. - Simplified test code and updated Array/List initializers.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/src/test/java/eu/aylett/arc/ArcTest.java | Added @GuardedBy qualifiers to test helpers and updated Arc instantiation. |
| lib/src/main/java/eu/aylett/arc/internal/InnerArc.java | Removed CF suppression, adjusted @GuardedBy fields and method signatures. |
| lib/src/main/java/eu/aylett/arc/internal/ElementList.java | Dropped generics on ElementList, added guard annotations, renamed method. |
| lib/src/main/java/eu/aylett/arc/internal/Element.java | Changed loader/pool types, added guard annotations, removed suppressions. |
| lib/src/main/java/eu/aylett/arc/Arc.java | Broadened loader generic, switched to a pool‐lambda in computeIfAbsent. |
| config/checkstyle/checkstyle.xml | Enabled same‐line multiple annotations in Checkstyle config. |
Comments suppressed due to low confidence (5)
lib/src/test/java/eu/aylett/arc/ArcTest.java:43
- The @GuardedBy annotation is intended for guarding fields or methods with a lock name, not for type parameters—remove it or apply a lock qualifier to the field/method declaration instead.
public static <T> org.hamcrest.Matcher<@GuardedBy @PolyNull @Initialized T> equalTo(@GuardedBy @PolyNull T operand) {
lib/src/test/java/eu/aylett/arc/ArcTest.java:47
- Misuse of @GuardedBy on method parameters and type arguments; it should specify a lock and be applied to fields or methods rather than types.
public static <T> void assertThat(@GuardedBy @PolyNull T actual, Matcher<? super @GuardedBy @PolyNull T> matcher) {
lib/src/test/java/eu/aylett/arc/ArcTest.java:73
- The type-use @GuardedBy on a
List.ofcall is inappropriate—remove this annotation from the type argument.
assertThat(recordedValues, equalTo(List.<@GuardedBy Integer>of(1, 2, 1)));
lib/src/main/java/eu/aylett/arc/internal/InnerArc.java:43
- The @GuardedBy annotation requires a lock name (e.g., @GuardedBy("this")) to be effective; add the lock reference or remove the annotation.
private final @GuardedBy ElementList seenOnceLRU;
lib/src/main/java/eu/aylett/arc/internal/ElementList.java:35
- Dropping generic parameters on
ElementListweakens type safety; consider restoring<K, V>parameters.
class ElementList {
| @@ -271,6 +271,7 @@ Authors: Max Vetrenko, Mauryan Kansara, Ruslan Diachenko, Roman Ivanov. | |||
| <property name="id" value="AnnotationLocationMostCases"/> | |||
| <property name="tokens" | |||
| value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, RECORD_DEF, COMPACT_CTOR_DEF"/> | |||
| <property name="allowSamelineMultipleAnnotations" value="true"/> | |||
There was a problem hiding this comment.
Typo in property name: should be allowSameLineMultipleAnnotations (capital L in 'Line').
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid some checkstyle warnings by fixing guard annotations
Avoid spotbugs warnings by only passing in what we need