Don't apply Checker Framework to tests #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A big chunk of what we want to test is what happens when we break the invariants -- so we were suppressing a lot of warnings.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the application of the Checker Framework from the test suite so that invariant-breaking behavior can be tested without interference from checker warnings.
- Removed Checker Framework imports and annotations from test files.
- Adjusted assertion helper methods to use static imports from Hamcrest.
- Updated the build configuration to exclude tests from Checker Framework checks.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/test/java/eu/aylett/arc/ArcTest.java | Removed Checker Framework annotations and adjusted type annotations. |
| lib/build.gradle.kts | Configured the Checker Framework to exclude tests from validity checks. |
Comments suppressed due to low confidence (1)
lib/src/test/java/eu/aylett/arc/ArcTest.java:243
- The change from checking arc.checkSafety() every 1000 iterations to every 100 iterations increases the frequency of safety checks, which could slow down the tests. Please confirm that this new frequency is intentional given the testing context.
if (i % 100 == 0) {
| @@ -81,6 +82,7 @@ configure<CheckerFrameworkExtension> { | |||
| "org.checkerframework.common.initializedfields.InitializedFieldsChecker", | |||
| "org.checkerframework.checker.lock.LockChecker", | |||
| ) | |||
| excludeTests = true | |||
There was a problem hiding this comment.
[nitpick] Consider adding a brief comment explaining that tests are being excluded from Checker Framework processing, to clarify the reasoning for future maintainers.
Copilot uses AI. Check for mistakes.
|
Looks good. No mutations were possible for these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big chunk of what we want to test is what happens when we break the invariants -- so we were suppressing a lot of warnings.