8000 Add tooling for publishing to Central by andrewaylett · Pull Request #119 · andrewaylett/arc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add tooling for publishing to Central #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Conversation

andrewaylett
Copy link
Owner

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 2, 2025 17:59
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tooling to support publishing artifacts to Central by updating and extending GitHub workflow configurations. Key changes include updates to publish workflows with new permissions and tasks, conditional Gradle build scan steps, and adjustments to checkout depths for accurate versioning.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/publish.yml Updated publishing job name and tasks for GitHub Packages and OSSRH publishing.
.github/workflows/pitest.yml Modified checkout depth and added conditional Gradle setup steps.
.github/workflows/gradle.yml Revised Gradle setup with conditionals and introduced a build scan step.
Comments suppressed due to low confidence (2)

.github/workflows/publish.yml:13

  • [nitpick] Consider renaming 'publish-package' to a more descriptive name (e.g., 'publish-to-central') to clarify the purpose of this job.
publish-package:

.github/workflows/publish.yml:39

  • Verify that 'publishMavenJavaPublicationToGitHubPackagesRepository' is the correct Gradle task for publishing to GitHub Packages as intended.
run: ./gradlew publishMavenJavaPublicationToGitHubPackagesRepository

Comment on lines +39 to +45
if: github.actor != 'andrewaylett' && github.event_name != 'push'
with:
dependency-graph: 'generate-and-submit'

- name: Setup Gradle Build Scan
uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244 # v4
if: github.actor == 'andrewaylett' || github.event_name == 'push'
Copy link
Preview
Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Hardcoding 'andrewaylett' may reduce flexibility; consider externalizing the username to a configuration variable.

Suggested change
if: github.actor != 'andrewaylett' && github.event_name != 'push'
with:
dependency-graph: 'generate-and-submit'
- name: Setup Gradle Build Scan
uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244 # v4
if: github.actor == 'andrewaylett' || github.event_name == 'push'
if: github.actor != env.GITHUB_ACTOR_USERNAME && github.event_name != 'push'
with:
dependency-graph: 'generate-and-submit'
- name: Setup Gradle Build Scan
uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244 # v4
if: github.actor == env.GITHUB_ACTOR_USERNAME || github.event_name == 'push'

Copilot uses AI. Check for mistakes.

Comment on lines +36 to +42
if: github.actor != 'andrewaylett' && github.event_name != 'push'
with:
dependency-graph: 'generate-and-submit'

- name: Setup Gradle Build Scan
uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244 # v4
if: github.actor == 'andrewaylett' || github.event_name == 'push'
Copy link
Preview
Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Hardcoding 'andrewaylett' can impact maintainability; consider using a configurable parameter instead.

Suggested change
if: github.actor != 'andrewaylett' && github.event_name != 'push'
with:
dependency-graph: 'generate-and-submit'
- name: Setup Gradle Build Scan
uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244 # v4
if: github.actor == 'andrewaylett' || github.event_name == 'push'
if: github.actor != secrets.ADMIN_USERNAME && github.event_name != 'push'
with:
dependency-graph: 'generate-and-submit'
- name: Setup Gradle Build Scan
uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244 # v4
if: github.actor == secrets.ADMIN_USERNAME || github.event_name == 'push'

Copilot uses AI. Check for mistakes.

Copy link
github-actions bot commented Jun 2, 2025

Looks good. No mutations were possible for these changes.
See https://pitest.org

@andrewaylett andrewaylett merged commit 21260ee into main Jun 2, 2025
6 checks passed
@andrewaylett andrewaylett deleted the push-ypvvwytuptrw branch June 2, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0