Groupvel #30
Open
Groupvel #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| [~,~,vs1,vs2,vp,~,~,PE,S1E,S2E,XIS] = MS_phasevels(C,rh,inc,azi); | ||
|
|
||
| SNP = zeros(length(azi),3) ; |
There was a problem hiding this comment.
Could you tidy up the indentation?
|
Thanks - looks good. I've added a handful of in-line comments. If you could change things and push to your branch it will show up here. Also, any chance of a test case and do we need to update the main documentation? |
|
I've made most of the changes. I'll try to come up with a nice test case next week. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated MS_Phasevels to add optional outputs (P, S1 and S2 eigenvectors, as well as phase propagation vector) and added MS_groupvels.
MS_groupvels outputs the group velocity in vector format corresponding to a given phase angle (Note that these are generally not parallel to each other). It also optionally outputs phase polarizations (eigenvectors) and the slowness vectors.
A potential issue with this is that S1 and S2 are currently sorted by phase velocity magnitudes, but since one phase vector corresponds to separate group vectors for P, S1 and S2, this doesn't translate to group velocities very well (see the attached figure for an example: blue is "S1" and red is "S2"). They should probably be sorted by which S velocity sheet they belong to. This is simple enough to do for VTI media (by sorting based on S polarisation), but I'm not sure how to do this for the general case.