Fix: remove redundant reference to companion objects #149
Conversation
There was a problem hiding this comment.
Hello @chikoski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request focuses on removing redundant references to companion objects in the codebase. Specifically, it updates several composable functions within the VideoPreview.kt, EmptyTimeline.kt, MetadataOverlay.kt, TimelineCard.kt, TimelineFormat.kt, TimelineScaffold.kt, and TimelineVerticalPager.kt files to directly reference the static members of ContentScale, Color, BlendMode, and Alignment instead of accessing them through their respective Companion objects. This change simplifies the code and improves readability.
Highlights
- Code Cleanup: Removes unnecessary
Companionobject references for static members in Compose modifiers and other UI elements. - Improved Readability: Simplifies code by directly accessing static members, making the code easier to understand and maintain.
Changelog
Click here to see the changelog
- app/src/main/java/com/google/android/samples/socialite/ui/components/VideoPreview.kt
- Removed
ContentScale.Companion.Fitand replaced withContentScale.Fit. - Removed
ColorFilter.Companion.tint(Color.Companion.Gray, BlendMode.Companion.Darken)and replaced withColorFilter.tint(Color.Gray, BlendMode.Darken)in multiple function overloads.
- Removed
- app/src/main/java/com/google/android/samples/socialite/ui/home/timeline/component/EmptyTimeline.kt
- Removed
Alignment.Companion.CenterHorizontallyand replaced withAlignment.CenterHorizontally. - Removed
Modifier.Companion.paddingand replaced withModifier.padding.
- Removed
- app/src/main/java/com/google/android/samples/socialite/ui/home/timeline/component/MetadataOverlay.kt
- Removed
Modifier.Companionprefixes from modifier chains, usingModifierdirectly. - Removed
Alignment.Companion.TopEndand replaced withAlignment.TopEnd. - Removed
Alignment.Companion.BottomStartand replaced withAlignment.BottomStart. - Removed
Alignment.Companion.CenterVerticallyand replaced withAlignment.CenterVertically. - Removed
Color.Companion.LightGrayand replaced withColor.LightGray.
- Removed
- app/src/main/java/com/google/android/samples/socialite/ui/home/timeline/component/TimelineCard.kt
- Removed
Modifier.Companionand replaced withmodifierdirectly.
- Removed
- app/src/main/java/com/google/android/samples/socialite/ui/home/timeline/component/TimelineFormat.kt
- Removed
WindowSizeClass.Companion.WIDTH_DP_MEDIUM_LOWER_BOUNDand replaced withWindowSizeClass.WIDTH_DP_MEDIUM_LOWER_BOUND.
- Removed
- app/src/main/java/com/google/android/samples/socialite/ui/home/timeline/component/TimelineScaffold.kt
- Removed
Modifier.Companion.fillMaxSize()and replaced withModifier.fillMaxSize().
- Removed
- app/src/main/java/com/google/android/samples/socialite/ui/home/timeline/component/TimelineVerticalPager.kt
- Removed
Modifier.Companionprefixes from modifier chains, usingModifierdirectly. - Removed
Alignment.Companion.Centerand replaced withAlignment.Center. - Removed
ContentScale.Companion.Fitand replaced withContentScale.Fit.
- Removed
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Companion objects, a Kotlin grace,
Sometimes redundant, taking up space.
This PR cleans,
What code convenes,
A neater, more elegant trace.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes redundant references to companion objects in the Kotlin code. The changes look good and improve code clarity by simplifying the syntax.
Summary of Findings
- Redundant Companion Object References: The primary focus of this PR is to remove unnecessary
Companionobject references, which simplifies the code and makes it more readable. This is a good practice in Kotlin.
Merge Readiness
The pull request is ready for merging. The changes are straightforward and improve the code's readability by removing redundant Companion object references. I am unable to approve the pull request, and users should have others review and approve this code before merging.
This PR removes redundant references to companion objects.