Pass context for calling IconCompat.toIcon #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`androidx.core.graphics.drawable.IconCompat.toIcon()` is deprecated, we should avoid calling it in core lib to prevent the exception thrown like:
```
java.lang.IllegalArgumentException: Context is required to resolve the file uri of the icon: content://com.google.android.samples.socialite/icon/1
at androidx.core.graphics.drawable.IconCompat$Api23Impl.toIcon(IconCompat.java:1297)
at androidx.core.graphics.drawable.IconCompat.toIcon(IconCompat.java:529)
at androidx.core.graphics.drawable.IconCompat.toIcon(IconCompat.java:517)
at androidx.core.app.Person$Api28Impl.toAndroidPerson(Person.java:427)
at androidx.core.app.Person.toAndroidPerson(Person.java:152)
at androidx.core.app.NotificationCompatBuilder.<init>(NotificationCompatBuilder.java:263)
at androidx.core.app.NotificationCompat$Builder.build(NotificationCompat.java:2531)
at com.google.android.samples.socialite.repository.NotificationHelper.showNotification(NotificationHelper.kt:274)
at com.google.android.samples.socialite.repository.NotificationHelper.showNotification$default(NotificationHelper.kt:159)
at com.google.android.samples.socialite.repository.ChatRepository$sendMessage$2.invokeSuspend(ChatRepository.kt:92)
```
Test: ./gradlew :core:core:check
Change-Id: I9c3874ae91efbb382693f679cadad62a9cba4a83
62d768f to
d3a2031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the cod
2F5B
e.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
androidx.core.graphics.drawable.IconCompat.toIcon()is deprecated, we should avoid calling it in core lib to prevent the exception thrown like:Testing
./gradlew :core:core:checkIssues Fixed
This will fix the issue reported at android/socialite#41, you can see more details and context there.