Use sequences for lazy evaluation #702
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of filtering and then casting, we use mapNotNull to both filter and cast in one step, making the code cleaner.
|
Drive-by review - I'll defer to @jbw0033 and @ianhanniballake as the owners if they want to override. In general manually testing is not good enough. Performance improvements should have a microbenchmark that shows the improvement. How much overhead does this add and at what point does it start paying off? We are also still filtering twice on the key and value separately, and it seems like we should combine that too. |
|
This begs to become a simple for loop :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use of Sequences: By converting the collection to a sequence using asSequence(), we enable lazy evaluation, which can improve performance when dealing with large collections by avoiding unnecessary intermediate collections.
Map Not Null: Instead of filtering and then casting, we use mapNotNull to both filter and cast in one step, making the code cleaner.
Testing
Manually
Issues Fixed
Use sequences for lazy evaluation