10000 [MediaRouter] Replace some PNGs with Vector Drawables by MGaetan89 · Pull Request #774 · androidx/androidx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MediaRouter] Replace some PNGs with Vector Drawables #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: androidx-main
Choose a base branch
from
Open

[MediaRouter] Replace some PNGs with Vector Drawables #774

wants to merge 1 commit into from

Conversation

MGaetan89
Copy link
Contributor
@MGaetan89 MGaetan89 commented May 10, 2025 •
edited
Loading

Proposed Changes

  • Replace some PNG drawables with the equivalent vector drawables.
  • Update existing vector drawables with the latest Material version.

Notes

  • The remaining PNGs are used for animations. I've left them untouched on purpose to keep this PR simple. I'll look into them in a follow-up PR.
  • I've kept the differentiation between light and dark drawables to not remove any drawable name. It should be possible to keep only one of each and use theme attributes for tinting.
  • Every vector drawable comes from https://fonts.google.com/icons. Some visuals may have changed slightly compared to the original PNGs.

Testing

Test: I successfully ran the unit tests and Android tests locally.

The Android tests have been run on an API 21 Pixel 8 Pro emulator.

I've also tested in a custom library (SRGSSR/androidx-mediarouter-compose), on a Pixel 7 Pro running Android 16. I don't have any older devices to try these changes.

Issues Fixed

Fixes: might help fixing https://issuetracker.google.com/issues/284912701

@MGaetan89 MGaetan89 marked this pull request as ready for review May 11, 2025 09:06
@MGaetan89 MGaetan89 requested review from dlam and yigit as code owners May 11, 2025 09:06
@MGaetan89 MGaetan89 force-pushed the vector_drawables branch 5 times, most recently from b6d9e99 to d1136ef Compare May 19, 2025 07:16
@MGaetan89 MGaetan89 force-pushed the vector_drawables branch 4 times, most recently from 2da0f6a to e21c51b Compare May 26, 2025 05:52
@MGaetan89 MGaetan89 force-pushed the vector_drawables branch 2 times, most recently from 4eeba01 to 5007850 Compare June 1, 2025 15:03
@MGaetan89 MGaetan89 force-pushed the vector_drawables branch 3 times, most recently from a2469c4 to 63690a2 Compare June 11, 2025 12:02
@MGaetan89 MGaetan89 force-pushed the vector_drawables branch 2 times, most recently from a4215a5 to f638e65 Compare June 16, 2025 07:54
@MGaetan89 MGaetan89 force-pushed the vector_drawables branch 2 times, most recently from 97c44d4 to e1c18db Compare June 25, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liutikas liutikas liutikas approved these changes

@dlam dlam Awaiting requested review from dlam dlam is a code owner

@yigit yigit Awaiting requested review from yigit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @liutikas
0