8000 Rename `iteration()` => `iterate()` by andywer · Pull Request #6 · andywer/leakage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename iteration() => iterate() #6

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2016
Merged

Rename iteration() => iterate() #6

merged 1 commit into from
Dec 28, 2016

Conversation

andywer
Copy link
Owner
@andywer andywer commented Dec 28, 2016

Replacing the #1 PR.

  • Renaming iteration() to iterate() instead of changing the docs
  • Keeping the iteration() export, but with a @deprecated

@kroogs @btmills

@andywer andywer changed the title Rename iteration() => iterate Rename iteration() => iterate() Dec 28, 2016
@andywer
Copy link
Owner Author
andywer commented Dec 28, 2016

Feel free to review it, but I am going to merge it quite soon, since it's max priority.

btmills
btmills approved these changes Dec 28, 2016
View reviewed changes
Copy link
@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Isn't it fun that Travis is failing simply because this branch doesn't have any .travis.yml config? 😁

@andywer
Copy link
Owner Author
andywer commented Dec 28, 2016

@btmills Lol. Gonna fix that, too, very soon 😉

@andywer andywer merged commit f2049ef into master Dec 28, 2016
@andywer andywer deleted the bugfix/iterate-method-name branch December 28, 2016 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btmills btmills btmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andywer @btmills
0