Fix NoMethodError when no request and cookies == :none
#554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5ac2a1 to
a0d10c1
Compare
NoMethodError when cookies == :none
a0d10c1 to
8aaaed4
Compare
NoMethodError when cookies == :noneNoMethodError when controllerless tracking and cookies == :none
8aaaed4 to
4f54499
Compare
NoMethodError when controllerless tracking and cookies == :noneNoMethodError when no request and cookies == :none
When tracking with no request, ``` Ahoy.cookies = :none Ahoy::Tracker.new.track_event(:would_fail) ``` would raise NoMethodError: undefined method `remote_ip' for nil. Since we explicitly don't have a request, allow visitor_token_helper to fall back on generate_id by returning nil from visitor_anonymity_set when there is no request.
4f54499 to
b3c2b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tracking with no request,
would raise
NoMethodError: undefined method 'remote_ip' for nil. Since we explicitly don't have arequest, allowvisitor_token_helperto fall back ongenerate_idby returningnilfromvisitor_anonymity_setwhen there is no
request.