8000 [4.0.0] Add sanity check for non-regular files in plugins/ by felixfontein · Pull Request #428 · ansible-collections/community.network · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[4.0.0] Add sanity check for non-regular files in plugins/ #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2022
Merged

[4.0.0] Add sanity check for non-regular files in plugins/ #428

merged 2 commits into from
May 25, 2022

Conversation

felixfontein
Copy link
Collaborator
SUMMARY

Follow-up to #426, will fail until that one is merged. It will report all symlinks or other non-regular files in plugins/.

I also included support for .yml files in plugins/test/ and plugins/filter/ for the upcoming sidecar docs feature of ansible-core 2.14 (ansible/ansible#74963). Not sure whether this is really needed, but if someone ever wants to add test and filter plugins to this collection, it will save them some pain :)

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

CI

@felixfontein felixfontein mentioned this pull request Apr 27, 2022
Merged
@bcoca
Copy link
bcoca commented Apr 27, 2022 •
edited
Loading

fyi, the.yml files are now permitted to document any of the 'documentable' plugins, but most likely the use will be for 'non python modules' to use .yml instead of a .py doc stub.

@felixfontein
Copy link
Collaborator Author

Restarting tests.

@felixfontein felixfontein reopened this May 25, 2022
@Ompragash Ompragash closed this May 25, 2022
@Ompragash Ompragash reopened this May 25, 2022
@Ompragash
Copy link
Member

Thanks for the PR @felixfontein!

@Ompragash Ompragash merged commit 0dae599 into ansible-collections:main May 25, 2022
@felixfontein felixfontein deleted the compatibility-sanity branch May 25, 2022 11:37
@felixfontein
Copy link
Collaborator Author

@bcoca @Ompragash thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @bcoca @Ompragash
0