-
Notifications
You must be signed in to change notification settings - Fork 403
ecs_cluster capacity provider strategy #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
softwarefactory-project-zuul
merged 38 commits into
ansible-collections:main
from
karcadia:770_ecs_capacity_provider_strategy
Jan 23, 2023
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
8cfea5d
Merge conflict.
karcadia f1b34f5
Some lines are too long.
karcadia d03d6d5
Provide more detail to argument spec and documentation.
karcadia 19400ee
PEP8 Indentation Rules.
karcadia 4ac5d21
Indentation Rules.
karcadia bfa1fc5
Spaces everywhere.
karcadia efc3336
Probably trading an indent error for a line long error.
karcadia fd8521c
refactor to avoid line splitting
karcadia 1c7ff8c
Linting / Indentation
karcadia fd17f51
Linting / Indentation
karcadia 15b9f32
Fix idempotency
karcadia 2f52d93
Refactor to avoid assert.
karcadia e429046
Merge conflicts / rebase.
karcadia 7e655bd
Merge conflicts / rebase.
karcadia 083ef77
Merge conflicts / rebase.
karcadia a5ffc34
Linting / Indentation
karcadia 8d1dc43
Formatting / Whitespace
karcadia f600cc4
Update changelogs/fragments/770-ecs-capacity-provider-strategy.yml
markuman 1009ed3
Update plugins/modules/ecs_cluster.py
markuman 016e426
Update plugins/modules/ecs_cluster.py
markuman 87b6584
Update plugins/modules/ecs_cluster.py
markuman 020cd62
Add toggle for purge_capacity_providers and ensure a default base is …
karcadia 52b943e
Catch purge_capacity_providers earlier so we can retain idempotency.
karcadia 89ed2b9
Create cluster also needs to use our variables with the base default …
karcadia 37f3976
Flip the logic on purge_capacity_providers and catch a condition wher…
karcadia ca37ba7
Add import for camel_dict_to_snake_dict.
karcadia 1dead45
Both loops check requested_cps so that cannot be None.
karcadia 52fd322
Need to also trigger an update when a strategy is in existing but now…
karcadia 400211c
Add purge_capacity_providers to the documentation.
karcadia e330238
Let the argument_spec handle defaulting to 0.
karcadia 6af6c41
Add purge_capacity_providers default to the documentation.
karcadia a68d816
Provide a warning to the user that some of their request will be igno…
karcadia f957ebf
Update changelogs/fragments/770-ecs-capacity-provider-strategy.yml
markuman d31c8af
Integration test should use purge_capacity_providers True for now.
karcadia ffe6d23
Only extract detail from existing when existing cluster exists and is…
karcadia 67be965
Fix idempotency -- override cps_update_needed to false as part of pur…
karcadia 7b353b1
Update plugins/modules/ecs_cluster.py
markuman 265df83
Update plugins/modules/ecs_cluster.py
markuman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
minor_changes: | ||
- ecs_cluster - add support for ``capacity_providers`` and ``capacity_provider_strategy`` features (https://github.com/ansible-collections/community.aws/pull/1640). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.