-
Notifications
You must be signed in to change notification settings - Fork 403
aws_ssm - Add FileTransferManager class #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ssm - Add FileTransferManager class #2273
Conversation
fffce05
to
ea6082f
Compare
recheck |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 41s (non-voting) |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 40s (non-voting) |
recheck |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 43s (non-voting) |
30c500b
to
239a0d6
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 04s (non-voting) |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s (non-voting) |
recheck |
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 11s (non-voting) |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 39s (non-voting) |
b91a63a
to
a1e54eb
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 17s (non-voting) |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 7m 59s (non-voting) |
plugins/plugin_utils/ssm/common.py
Outdated
|
||
continue | ||
|
||
return return_tuple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’re returning return_tuple outside the retry loop, but if all retries fail, it will be undefined. What do you think about returning directly inside the try block?
:param in_path: The local destination path for the file. | ||
:param out_path: The remote source path of the file. | ||
:param commands: The transport commands to execute. | ||
:param bucket: The S3 bucket name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:param bucket: The S3 bucket name. |
:param in_path: The local source path of the file. | ||
:param out_path: The remote destination path for the file. | ||
:param commands: The transport commands to execute. | ||
:param bucket: The S3 bucket name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:param bucket: The S3 bucket name. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
046b1bf
to
0148294
Compare
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
5164b18
to
8658fb1
Compare
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 33s (non-voting) |
4284a3f
to
b76409c
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 44s (non-voting) |
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
b76409c
to
8271179
Compare
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 3m 47s (non-voting) |
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 3m 38s (non-voting) |
705a8fa
into
ansible-collections:main
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #2288 🤖 @patchback |
SUMMARY Add FileTransferManager class ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm Reviewed-by: GomathiselviS <gomathiselvi@gmail.com> Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> (cherry picked from commit 705a8fa)
…s#2273) SUMMARY Add FileTransferManager class ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm Reviewed-by: GomathiselviS <gomathiselvi@gmail.com> Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@705a8fa
SUMMARY
Add FileTransferManager class
ISSUE TYPE
COMPONENT NAME
aws_ssm