Updated keycloak.py to allow defining connection timeout value (#4168) #4178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Also CC @fynncfchen since this will 8000 affect the new modules PRs. The code they add (to module_utils) will have to be modified to use the timeout parameter as well. |
kris2kris
approved these changes
Feb 12, 2022
pmdumuid
approved these changes
Feb 14, 2022
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4198 🤖 @patchback |
|
@laskasn thanks for contributing this! |
felixfontein
pushed a commit
that referenced
this pull request
Feb 14, 2022
#4178) (#4198) * Updated keycloak.py to allow defining connection timeout value (#4168) (#2) * Added parameter to doc_fragments and edited the changelog message (#4168) * Added parameter to doc_fragments and edited the changelog message (#4168) (cherry picked from commit 2498591) Co-authored-by: Nikolas Laskaris <laskarisn@gmail.com>
This was referenced Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
You can find a summary along with a discussion here
IMPORTANT: This pull request adds a new parameter to the keycloak module, the
connection_timeout.If provided, it propagates this value as the optional value
timeoutto theopen_url()calls. By default (if not defined), it inherits the 10 sec default value of the underlyingtimeoutparameter.We decided to name it
connection_timeoutinstead of justtimeout, because we didn't want to have a naming collision with the task timeout parameter or the network-specific ones, as mentioned here, but we could rename it into anything else in case this name is not appropriate.The documentation should also be updated, to include this parameter as an optional to all keycloak plugin calls.
ISSUE TYPE
COMPONENT NAME
keycloak
ADDITIONAL INFORMATION