8000 [PR #5606/7ea544a6 backport][stable-6] New Module: Keycloak ClientSecret with PR changes by patchback[bot] · Pull Request #5654 · ansible-collections/community.general · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PR #5606/7ea544a6 backport][stable-6] New Module: Keycloak ClientSecret with PR changes #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patchback[bot]
Copy link
@patchback patchback bot commented Dec 5, 2022

This is a backport of PR #5606 as merged into main (7ea544a).

SUMMARY

Updated version of PR #3997 by @fynncfchen

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

keycloak_clientsecret

ADDITIONAL INFORMATION

I rebased the original PR and made all of the changes, plus one or two extra

  • Structure of plugins/modules changed since original PR. No symlinks present after rebase.
  • Added an entry in meta/runtime.yml to help anyone using keycloak_clientsecret in fynncfchen:keycloak-clientsecret (4.3.0) switching to the version that includes this PR, where the structure of plugins/modules has changed.
  • All suggested changes from @felixfontein and @russoz implemented
  • Changed version added from 4.4.0 to 6.1.0

Testing

I tested the following:

  • Built docs - they look OK
  • Used the module with the following args to retrieve my keycloak client secret as part of my home network setup: auth_client_id, auth_keycloak_url, auth_realm, auth_username, auth_password, state, realm, client_id - it worked first time with no code changes needed.
  • Nothing else tested by me

* feat(plugins/keycloak): add get and create util function for client secret

* feat(plugins/keycloak): add client secret module

* chore: add maintainer in BOTMETA

* Update plugins/modules/identity/keycloak/keycloak_clientsecret.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Make changes to keycloak_clientsecret from PR

* Add SPDX identifier for keycloak_clientsecret

* Add copyright in keycloak_clientsecret for REUSE

* Add integration test for keycloak_clientsecret

* rm clientsecret from keycloak_clientsecret result

  - end_state used instead

* keycloak_clientsecret: Undo meta/runtime.yml change

* Fix sanity tests for keycloak_clientsecret

* New keycloak_clientsecret_info module

  - Replaces keycloak_clientsecret
  - Module definition and some common logic moved into module_utils
  - Update documentation, tests, etc.
  - Add myself as author

* Misc fixes to keycloak_clientsecret_info

* Add keycloak_clientsecret_regenerate module

* keycloak_clientsecret* Update .github/BOTMETA.yml

* keycloak_clientsecret_regenerate: Fix sanity tests

* Fix README for keycloak_clientsecret integration test

* Separate out keycloak_clientsecret module_utils

* Keycloak_clientsecret module_utils: boilerplate

* Update plugins/modules/keycloak_clientsecret_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_clientsecret_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_clientsecret_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_clientsecret_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_clientsecret_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_clientsecret_info.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* keycloak_clientsecret: Add no_log to examples and docs

* keycloak_clientsecret: Update BOTMETA

* Update .github/BOTMETA.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: fynncfchen <fynn.cfchen@gmail.com>
Co-authored-by: Fynnnnn <ethan.cfchen@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 7ea544a)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport identity integration tests/integration module module module_utils module_utils new_contributor Help guide this first time contributor new_plugin New plugin plugins plugin (any type) tests tests labels Dec 5, 2022
@felixfontein felixfontein merged commit 8a231e4 into stable-6 Dec 5, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-6/7ea544a6244c7324e45c6972cdf0b6674797e0e9/pr-5606 branch December 5, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
identity integration tests/integration module_utils module_utils module module new_contributor Help guide this first time contributor new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0