Added missing examples of some parameters. #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing examples explaining the correct use of the following parameters: pubkey, api_token_id, api_token_secret
Added what kind of token is being mentioned.
|
My struggle is documented here. By the time I created the issue, I had already spent several hours getting token authentication to work through trial and error. |
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 59.39% 59.39%
=======================================
Files 42 42
Lines 4576 4576
Branches 936 936
=======================================
Hits 2718 2718
Misses 1729 1729
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Troubleshooted my playbook for way too long through trial and error because there weren't any examples of pubkey, api_token_id, api_token_secret parameters.
Decided to add examples for next people who might struggle with these.
ISSUE TYPE
COMPONENT NAME
community.proxmox.proxmox
ADDITIONAL INFORMATION
N/A