Zabbix actions discovery checks with condtions #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
==========================================
+ Coverage 78.99% 79.05% +0.05%
==========================================
Files 47 47
Lines 5946 5958 +12
Branches 1535 1539 +4
==========================================
+ Hits 4697 4710 +13
+ Misses 769 768 -1
Partials 480 480 ☔ View full report in Codecov by Sentry. |
Fix after sanity test
Found 1 pep8 issue(s) which need to be resolved: ERROR: plugins/modules/zabbix_action.py:812:1: E302: expected 2 blank lines, found 1
BGmot
reviewed
Mar 1, 2025
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
| - zabbix_action module add discovery check condition in discovery rule. | |||
There was a problem hiding this comment.
Please make it a bit more verbose. Currently discovery rules already have discovery check condition.
BGmot
reviewed
Mar 1, 2025
Co-authored-by: Evgeny Yurchenko <ey@bgmot.com>
BGmot
approved these changes
Mar 3, 2025
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1409
Creating discovery action with conditions.type=discovery_check and dchecks.type=Zabbix throw error.
One discovery rule can have many checks with same type - "Zabbix agent", but with different keys.
ISSUE TYPE
COMPONENT NAME
zabbix_action module
ADDITIONAL INFORMATION