8000 Fix Zabbix proxy with encryption registration by BGmot · Pull Request #1483 · ansible-collections/community.zabbix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Zabbix proxy with encryption registration #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 9, 2025
Merged

Fix Zabbix proxy with encryption registration #1483

merged 9 commits into from
Mar 9, 2025

Conversation

BGmot
Copy link
Collaborator
@BGmot BGmot commented Mar 9, 2025
SUMMARY

Fixes #1418

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zabbix_proxy role

@BGmot BGmot requested review from eb4x and pyrodie18 March 9, 2025 01:08
@BGmot BGmot self-assigned this Mar 9, 2025
pyrodie18
pyrodie18 approved these changes Mar 9, 2025
View reviewed changes
Copy link
Collaborator
@pyrodie18 pyrodie18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BGmot looks good. My only comment would be you didn't update the .github file to trigger the new molecule test.

@BGmot
Copy link
Collaborator Author
BGmot commented Mar 9, 2025

@BGmot looks good. My only comment would be you didn't update the .github file to trigger the new molecule test.

Thanks Troy, totally missed that though locally tested everything. This is why a review is required -)

@BGmot
Copy link
Col 8000 laborator Author
BGmot commented Mar 9, 2025

Don't merge please yet. I have some thought that will probably result in more changes.

eb4x
eb4x approved these changes Mar 9, 2025
View reviewed changes
Copy link
Collaborator
@eb4x eb4x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BGmot BGmot merged commit f7ed088 into ansible-collections:main Mar 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb4x eb4x eb4x approved these changes

@pyrodie18 pyrodie18 pyrodie18 approved these changes

Assignees

@BGmot BGmot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task "Ensure proxy definition is up-to-date (added/updated/removed)" in "zabbix_proxy" module seems to be not compatible with zabbix 7
3 participants
@BGmot @eb4x @pyrodie18
0