8000 Fix win_group_membership integration tests by ronger4 · Pull Request #665 · ansible-collections/ansible.windows · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix win_group_membership integration tests #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix win_group_membership integration tests #665

merged 1 commit into from
Nov 19, 2024

Conversation

ronger4
Copy link
Contributor
@ronger4 ronger4 commented Oct 14, 2024

Integration test fix and adapt files to pass ansible-lint warning and errors

SUMMARY
  • Fixed an issue in which integration test was failing on conditional check and it can’t be evaluated.
  • Fixed errors and warning that ansible-lint was showing.
ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION
Before My change the following error occured during the integration test run for win_group_membership integration test:
fatal: [windows_server]: FAILED! => {
    "msg": "The conditional check 'add_another_user_to_group_again.members == [\"{{ ansible_hostname }}\\\\{{ admin_account_name }}\", \"{{ ansible_hostname }}\\\\{{ win_local_user }}\", \"NT AUTHORITY\\\\SYSTEM\", \"NT AUTHORITY\\\\NETWORK SERVICE\"]' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated."
}

p3ck
p3ck approved these changes Oct 14, 2024
View reviewed changes
Copy link
@p3ck p3ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

@github-actions github-actions bot added the stale label Nov 12, 2024
@jborean93 jborean93 closed this Nov 14, 2024
@jborean93 jborean93 reopened this Nov 14, 2024
@ronger4 @jborean93
Fix win_group_membership integration tests
2969868 
Integration test fix and adapt files to pass ansible-lint warning and errors
@jborean93 jborean93 force-pushed the fix/win_group_membership branch from 975550d to 2969868 Compare November 19, 2024 00:18
@jborean93 jborean93 merged commit 9722494 into ansible-collections:main Nov 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p3ck p3ck p3ck approved these changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronger4 @p3ck @jborean93
0