profile_* callbacks: avoid deprecated/deleted functions #650
Conversation
|
Build failed.
|
|
Zuul is currently broken, so the failing tests there are not surprising (https://forum.ansible.com/t/43604). |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 14s |
|
Ping @saito-hideki this affects ansible-core 2.19 compatibility. |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 14s |
c273ac2
into
ansible-collections:main
|
@felixfontein @Akasurde I will backport this pull request to stable-1 and stable-2 as well. |
|
@Akasurde @saito-hideki thanks for reviewing and merging! |
profile_* callbacks: avoid deprecated/deleted functions SUMMARY The profile_roles and profile_tasks callbacks define methods playbook_on_setup and playbook_on_stats which have been deleted/deprecated: playbook_on_stats has been deprecated, v2_playbook_on_stats should be used instead (that one has already been there for many years: ansible/ansible@ba0e532 was added in 2015). playbook_on_setup has been deleted (ansible/ansible@eec57ec), and its v2 variant was already deleted in 2017: ansible/ansible@59d5481 Ref: ansible-collections#635 ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME profile_roles profile_tasks Reviewed-by: Abhijeet Kasurde Reviewed-by: Hideki Saito <saito@fgrep.org>
SUMMARY
The profile_roles and profile_tasks callbacks define methods
playbook_on_setupandplaybook_on_statswhich have been deleted/deprecated:playbook_on_statshas been deprecated,v2_playbook_on_statsshould be used instead (that one has already been there for many years: ansible/ansible@ba0e532 was added in 2015).playbook_on_setuphas been deleted (ansible/ansible@eec57ec), and its v2 variant was already deleted in 2017: ansible/ansible@59d5481Ref: #635
ISSUE TYPE
COMPONENT NAME
profile_roles
profile_tasks