8000 Added configurable token_auth_method by Yaish25491 · Pull Request #478 · ansible-collections/servicenow.itsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added configurable token_auth_method #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Added configurable token_auth_method #478

merged 1 commit into from
Jun 23, 2025

Conversation

Yaish25491
Copy link
Collaborator
SUMMARY

Added configurable token_auth_method parameter to support both x-sn-apikey and Authorization Bearer headers for access tokens

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/arguments.py
plugins/module_utils/client.py
tests/integration/targets/api_authentication/tasks/main.yml
ests/unit/plugins/module_utils/test_client.py

ADDITIONAL INFORMATION

Uses the API-key method as default, the User can choose Bearer method by stating:
"token_auth_method": "bearer"

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/295fffcdaa8542f6b6313c988259bdd7

✔️ ansible-galaxy-importer SUCCESS in 3m 22s
✔️ build-ansible-collection SUCCESS in 5m 50s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/972c5249ae584f8ab7f7837b1857138e

✔️ ansible-galaxy-importer SUCCESS in 3m 26s
✔️ build-ansible-collection SUCCESS in 5m 46s

@Yaish25491 Yaish25491 requested a review from mhjacks June 18, 2025 12:10
mhjacks
mhjacks reviewed Jun 18, 2025
View reviewed changes
@mhjacks
Copy link
Collaborator
mhjacks commented Jun 18, 2025

Noted: The test failures are a known issue and not related to this change

mikemorency
mikemorency reviewed Jun 18, 2025
View reviewed changes
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4d226449bf194c60bd54b84016e3a045

✔️ ansible-galaxy-importer SUCCESS in 3m 09s
✔️ build-ansible-collection SUCCESS in 5m 49s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c575ab83f2cf441daf9df655b227f1cd

✔️ ansible-galaxy-importer SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 6m 03s

@mikemorency mikemorency self-requested a review June 20, 2025 15:59
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d720d05b5bb5418d839b74a9954b667d

✔️ ansible-galaxy-importer SUCCESS in 3m 19s
✔️ build-ansible-collection SUCCESS in 5m 48s
< 8000 !-- -->
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3deb1f164aac461197e4c211f293577a

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 5m 49s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/053181115ccc44c2a612e7deddbae825

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 6m 49s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0b26b9deb54f42caa98b593abc96c78a

✔️ ansible-galaxy-importer SUCCESS in 3m 16s
✔️ build-ansible-collection SUCCESS in 5m 53s

@Yaish25491 Yaish25491 force-pushed the ACA-2513 branch 2 times, most recently from 007b634 to 329fbb2 Compare June 23, 2025 14:24
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/55c23bd542c5491ba1546c31c71bc715

✔️ ansible-galaxy-importer SUCCESS in 7m 54s
✔️ build-ansible-collection SUCCESS in 5m 44s

@mhjacks @Yaish25491
Merge pull request ansible-collections#474 from mikemorency/feature/c…
6867900 
…lient-creds-inventory

adding oauth client_credentials grant type to inven plugin
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/97f8ab38b9c1407ebd696d8b5332ec1e

✔️ ansible-galaxy-importer SUCCESS in 3m 32s
✔️ build-ansible-collection SUCCESS in 5m 49s

@mhjacks mhjacks merged commit dcf3624 into ansible-collections:main Jun 23, 2025
90 of 93 checks passed
@mhjacks mhjacks mentioned this pull request Jun 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhjacks mhjacks mhjacks left review comments

@mikemorency mikemorency mikemorency approved these changes

Assignees
No one assigned
Labels
safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yaish25491 @mhjacks @mikemorency
0