Add additional "safe" filters to entries in Vagrantfile #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2023
apatard
reviewed
May 30, 2023
test/vagrant/functional/test_func.py
Outdated
| # Validate Vagrantfile | ||
| vagrantdir = os.path.dirname(vagrantfile) | ||
| result = vagrant.Vagrant().validate(vagrantdir) | ||
| assert result.returncode == 0 |
There was a problem hiding this comment.
hm. Why is it needed ? iirc, the plugin code should already be running validate
There was a problem hiding this comment.
'Cause I'm a noob and didn't realize validate was being called.
I've removed it.
85c459f to
bf0b984
Compare
apatard
approved these changes
May 31, 2023
|
Thanks for your PR. I hope there's no more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggy-backing #141
Add some additional "safe" filters to other entries in the Vagrantfile.