8000 Hotfix: Correct cis_9_3_x rule number in skip_for_test description by mikeeq · Pull Request #26 · ansible-lockdown/Windows-11-CIS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hotfix: Correct cis_9_3_x rule number in skip_for_test description #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Hotfix: Correct cis_9_3_x rule number in skip_for_test description #26

wants to merge 1 commit into from

Conversation

mikeeq
Copy link
@mikeeq mikeeq commented Mar 27, 2025

Overall Review of Changes:
Simple correction of the text.

Issue Fixes:

Enhancements:

How has this been tested?:
It was tested on official win11 azure image.

github-actions[bot]
github-actions bot reviewed Mar 27, 2025
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

@mikeeq mikeeq force-pushed the hotfix/skip_for_tests_cis_9 branch from 892a90f to c0e5006 Compare March 27, 2025 07:37
@mikeeq mikeeq force-pushed the hotfix/skip_for_tests_cis_9 branch 2 times, most recently from 8a21217 to 26f16db Compare May 5, 2025 11:26
@mikeeq
Hotfix: Correct cis_9_3_x rule number in skip_for_test description
df82f07 
Signed-off-by: mikeeq <miotk.mikolaj@gmail.com>
@mikeeq mikeeq force-pushed the hotfix/skip_for_tests_cis_9 branch from 26f16db to df82f07 Compare May 5, 2025 12:57
@mikeeq
Copy link
Author
mikeeq commented May 5, 2025

@MrSteve81 please review, it's a simple change.

@MrSteve81
Copy link
Contributor

@mikeeq sorry about this really. I completely overlooked it. It will be approved today and I have made the adjustments in Windows 10 as well.

MrSteve81
MrSteve81 approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor
@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

frederickw082922
frederickw082922 approved these changes May 5, 2025
View reviewed changes
< 8000 div data-view-component="true" class="TimelineItem-body">
Copy link
Contributor
@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mikeeq

@MrSteve81 MrSteve81 mentioned this pull request May 5, 2025
Merged
@MrSteve81
Copy link
Contributor

For some weird reason merging is blocked even though you have a signature it must not be verified. I have done a PR and got it to devel. Also gave credit int he changelog to you.

@MrSteve81 MrSteve81 closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@MrSteve81 MrSteve81 MrSteve81 approved these changes

@frederickw082922 frederickw082922 frederickw082922 approved these changes

Assignees

@MrSteve81 MrSteve81

@frederickw082922 frederickw082922

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeeq @MrSteve81 @frederickw082922
0