This repository was archived by the owner on May 20, 2024. It is now read-only.
revamp support level enumeration in component matcher #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
+ Coverage 31.36% 31.45% +0.09%
==========================================
Files 47 47
Lines 9173 9195 +22
==========================================
+ Hits 2877 2892 +15
- Misses 6296 6303 +7 |
|
Other examples
|
webknjaz
reviewed
Nov 26, 2018
| # reconcile support levels | ||
| if filename in support_levels: | ||
| # exact match | ||
| meta['support'] = support_levels[filename] |
webknjaz
reviewed
Nov 26, 2018
| @@ -430,6 +431,8 @@ def __init__(self, filepath, email_cache=None): | |||
| @property | |||
| def filedata(self): | |||
| if self._FILEDATA is None: | |||
| if not os.path.exists(self.filepath): | |||
| return '' | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1099
tests TBD