This repository was archived by the owner on Mar 23, 2019. It is now read-only.
chore(travis) fixed typo ubuntu:beaver->bionic #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What, did they change the code name of the distro? Weird. Anyway, it's a one-line fix and I presume it's good, thanks @Voronenko :) |
|
For that specific case .travis.yml is not prepared - i.e. if there is typo in distribution name, PR tests pass, and repository tests later - fail. https://travis-ci.org/ansible/ansible-container/jobs/392654211 For sure, it needs to be improved, although that part is not changed that often. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
travis.yml : ubuntu 18.04 LTS was released,
makes sense to support tests for LTS