8000 Updated the Installing.md docs and updated the sample_test.py.j2 file by shvenkat-rh · Pull Request #386 · ansible/ansible-creator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updated the Installing.md docs and updated the sample_test.py.j2 file #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 25, 2025

Conversation

shvenkat-rh
Copy link
Contributor

Updated the docs and fixed an issue where sample_test.py had a function named _hello_world(args..). Renamed it to _sample_test(args..)

@shvenkat-rh shvenkat-rh added the documentation Improvements or additions to documentation label Mar 21, 2025
@shvenkat-rh shvenkat-rh self-assigned this Mar 21, 2025
@github-actions github-actions bot added the bug Something isn't working label Mar 21, 2025
@shvenkat-rh shvenkat-rh marked this pull request as ready for review March 21, 2025 15:34
@shvenkat-rh shvenkat-rh requested a review from a team as a code owner March 21, 2025 15:34
@shvenkat-rh shvenkat-rh marked this pull request as draft March 24, 2025 04:41
@shvenkat-rh shvenkat-rh marked this pull request as ready for review March 24, 2025 09:53
@shvenkat-rh shvenkat-rh marked this pull request as draft March 24, 2025 10:13
@shvenkat-rh shvenkat-rh marked this pull request as ready for review March 25, 2025 11:19
Copy link
Contributor
@shatakshiiii shatakshiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the review comments the PR looks good. We can merge it once those comments are addressed. Approving!!

@shvenkat-rh shvenkat-rh merged commit ed35e1c into ansible:main Mar 25, 2025
20 checks passed
@shvenkat-rh shvenkat-rh deleted the fix-test-and-docs branch March 25, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants
0