Link legacy to provider namespace #4286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
himdel
reviewed
Sep 22, 2023
jerabekjiri
reviewed
Sep 26, 2023
jerabekjiri
reviewed
Sep 26, 2023
src/components/legacy-namespace-list/legacy-namespace-provider.tsx
Outdated
Show resolved
Hide resolved
jerabekjiri
reviewed
Sep 26, 2023
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
|
cypress test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the legacy namespace summary and legacy role lists, "Provided by" now links to the v3 namespace where RBAC for the legacynamespace is actually managed. If no v3 namespace is linked, it'll be an empty string ... which is fine because we're not supposed to have that situation and it should be fixed for the user.