10000 Namespace - show name, not company (outside insights) by himdel · Pull Request #4302 · ansible/ansible-hub-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Namespace - show name, not company (outside insights) #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2023
Merged

Namespace - show name, not company (outside insights) #4302

merged 2 commits into from
Sep 27, 2023

Conversation

himdel
Copy link
Collaborator
@himdel himdel commented Sep 26, 2023 •
edited
Loading

for non-insights mode, just show namespace name always, instead of preferring namespace.company for the title

Affects collection header (logo alt), collection list item, collection card, namespace header and namespace card.

Issue: AAH-2722
Before 20230926181423 20230926181429 20230926181437
After 20230926181223 20230926181229 20230926181250
Before 20230926181412
After 20230926181242

@himdel
Namespace - show name, not company (outside insights)
cee366e 
for non-insights mode, just show namespace name always, instead of preferring namespace.company for the title

Affects collection header (logo alt), collection list item, collection card, namespace header and namespace card.

Issue: AAH-2722
@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Sep 26, 2023
@himdel himdel added community comunity mode feature and removed backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Sep 26, 2023
@himdel himdel marked this pull request as ready for review September 26, 2023 18:22
@himdel
namespace_edit: don't test company name in standalone
276e782 
(insights/namespace_edit unaffected)
nixocio
nixocio approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor
@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@himdel cypress screenshot is also failing. Other than that 👍

@himdel
Copy link
Collaborator Author
himdel commented Sep 27, 2023

Thanks, yeah, with repositories it's a false positive, but with namespaces it's a good failure .. noticed an actual change - since we're removing the company field on the list screen :)

@himdel himdel merged commit 13d377f into ansible:master Sep 27, 2023
@himdel himdel deleted the company branch September 27, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

@nixocio nixocio nixocio approved these changes

Assignees
No one assigned
Labels
community comunity mode feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@himdel @rochacbruno @nixocio
0