8000 ExternalLink by himdel · Pull Request #4382 · ansible/ansible-hub-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ExternalLink #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2023
Merged

ExternalLink #4382

merged 5 commits into from
Nov 12, 2023

Conversation

himdel
Copy link
Collaborator
@himdel himdel commented Oct 9, 2023

Split off from #4381

Add an ExternalLink component, to wrap the usual <a href="..." target="_blank" rel="noreferrer noopener">...</a> <ExternalLinkAltIcon /> combo.

Use everywhere.

@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 9, 2023
@himdel himdel added cleanup Dead code removal, etc and removed backport-4.7 This PR should be backported t 8000 o stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 9, 2023
@himdel himdel force-pushed the ext-link branch 8 times, most recently from a041e3b to f867a03 Compare November 11, 2023 06:14
@himdel himdel marked this pull request as ready for review November 11, 2023 06:14
use an `ExternalLink` (`{ href, title | children }`) component for all external links
(no other `_blank`, `ExternalLinkAltIcon`, `nofollow`, `noreferrer`, `noopener`; no other `<a>` except for `mailto:`)

No-Issue
    s/title={\([^}]*\)}\( \/>\)\?/>{\1}<\/ExternalLink>/

to match Link and prevent conflict with `title` as an `<a>` attribute
@himdel himdel merged commit e265e67 into ansible:master Nov 12, 2023
@himdel himdel deleted the ext-link branch November 12, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Dead code removal, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0