8000 Remove duplicate trailing slash on fetching legacy role versions and content by jctanner · Pull Request #4424 · ansible/ansible-hub-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove duplicate trailing slash on fetching legacy role versions and content #4424

New issue

Have a question abou 8000 t this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Remove duplicate trailing slash on fetching legacy role versions and content #4424

merged 1 commit into from
Oct 23, 2023

Conversation

jctanner
Copy link
Contributor
@jctanner jctanner commented Oct 22, 2023 •
edited
Loading

The UX on beta is fetching /api/v1/roles/{id}/versions// and /api/v1/roles/{id}/content//. On a local devstack the API routing is handling this fine and returning the data, but in the hosted environments it's giving 404's.

@jctanner
Remove duplicate trailing slash on fetching legacy role versions and …
4efa1bf 
…content.

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 22, 2023
@jctanner jctanner removed backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 22, 2023
jerabekjiri
jerabekjiri approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor
@jerabekjiri jerabekjiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm surprised we didn't notice this before 😵‍💫

@jctanner jctanner merged commit 4324cde into ansible:master Oct 23, 2023
@himdel himdel mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerabekjiri jerabekjiri jerabekjiri approved these changes

@himdel himdel Awaiting requested review from himdel

@MilanPospisil MilanPospisil Awaiting requested review from MilanPospisil

@ShaiahWren ShaiahWren Awaiting requested review from ShaiahWren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jctanner @jerabekjiri
0