[stable-4.9] Drop @redhat-cloud-services/frontend-components-config #4618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
add babel-loader since f-c-c 6 no longer depends on it, No-Issue
fcc 6 seems to insist on pf5 and apparently also fec.config.js makes sense for master, but simplifying for stable branches
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Nov 29, 2023
mostly updating master to reflect changes from ansible#4618, all of these are dependencies we're using, but only depenending on transitively No-Issue
himdel
added a commit
that referenced
this pull request
Nov 29, 2023
mostly updating master to reflect changes from #4618, all of these are dependencies we're using, but only depenending on transitively No-Issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4617
4.6: #4621
4.7: #4620
4.8: #4619
Drop
@redhat-cloud-services/frontend-components-config,along with
@redhat-cloud-services/frontend-componentsand@redhat-cloud-services/frontend-components-config-utilitiesonly used on master.f-c-c v5 dependencies are becoming stale, v6 seems to need
fec.config.jsetc,we don't need this for the stable branches, can just use a static webpack config.
(Add dependencies previously provided transitively through f-c-c)
Changes:
dev:
publicPathset to/notapps/automation-hub- webpack can serve it anywhere, no need to use insights defaultshistoryApiFallback.rewritesmagicHtmlMiniCssExtractPluginin devshared:
mjsfallback, not using those libraries in UItest: 'js'for sourcemaps (don't ignore css)cleanStaleWebpackAssets: true- not sure why we'd keep themprocess,BufferdefsCRC_APP_NAMEglobal, unusedprod:
devServer, only in devMiniCssExtractPluginignoreOrder: false