8000 Update run action to address templated task name for tasks in playbook by cidrblock · Pull Request #1202 · ansible/ansible-navigator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update run action to address templated task name for tasks in playbook #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 13, 2022
Merged

Update run action to address templated task name for tasks in playbook #1202

merged 7 commits into from
Apr 13, 2022

Conversation

cidrblock
Copy link
Collaborator
@cidrblock cidrblock commented Apr 12, 2022 •
edited
Loading

Fixes an instance where task names provided in a playbook_on_start event were templated, but the subsequent runner_on* events were not.

This creates a cache using the task_uuid and holds the playbook_on_start task for use later.

Rather than blindly update the task names, we will make a decision based on the "best" task name, replace one with a template with one without, or use an updated name if one is provided.

Tested locally

@cidrblock cidrblock changed the title Update run Update run action do address templated task name for tasks in playbook Apr 12, 2022
@cidrblock cidrblock changed the title Update run action do address templated task name for tasks in playbook Update run action to address templated task name for tasks in playbook Apr 12, 2022
@cidrblock cidrblock merged commit 9b31519 into ansible:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cidrblock @ganeshrn
0