8000 Fix settings issue when directing to a settings file by cidrblock · Pull Request #1225 · ansible/ansible-navigator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix settings issue when directing to a settings file #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2022

Conversation

cidrblock
Copy link
Collaborator

Fixes: #1224

In the case of settings --sample being directed to a settings file, allow it to be empty, but return immediately w/o processing it.

@cidrblock cidrblock changed the title Fix settings issue Fix settings issue when directing to a settings file May 10, 2022
@github-actions github-actions bot added the bug Researched, reproducible, committed to fix label May 10, 2022
Copy link
Member
@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm shipit

@cidrblock cidrblock merged commit eb73231 into ansible:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Researched, reproducible, committed to fix skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to write sample settings to a settings file
2 participants
0