8000 Add the become flag and become_user var to the callback plugin by damionparry · Pull Request #1391 · ansible/ansible-runner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add the become flag and become_user var to the callback plugin #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: devel
Choose a base branch
from
Open

Add the become flag and become_user var to the callback plugin #1391

wants to merge 6 commits into from

Conversation

damionparry
Copy link
  • Enables propagating the become flag and become user to external logs allowing the use of become to be audited

@damionparry
Add the become flag and become_user var to the callback plugin
de428fb 
* Enables propagating the become flag and become user to external logs allowing the use of become to be audited
@damionparry damionparry requested a review from a team as a code owner August 27, 2024 16:19
Tompage1994 and others added 2 commits September 2, 2024 15:21
@Tompage1994
Add callback integration test
1f7a9a2 
Signed-off-by: tompage1994@hotmail.co.uk <tpage@redhat.com>
@damionparry
Merge pull request #1 from Tompage1994/become_flags
3ec5606 
Add callback integration test
@Tompage1994
Copy link

@ansible/executor is it possible to get some traction on this PR? It's been awaiting a review for a long time now

Thanks

@Shrews Shrews closed this Apr 2, 2025
@Shrews Shrews reopened this Apr 2, 2025
@Shrews Shrews added the needs_triage New item that needs to be triaged label Apr 2, 2025
Tompage1994
Tompage1994 reviewed Apr 2, 2025
View reviewed changes
Tompage1994
Tompage1994 reviewed Apr 2, 2025
View reviewed changes
Copy link
@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an issue with the tests

@damionparry @Tompage1994
Update test/integration/test_display_callback.py
d2aee8c 
Co-authored-by: Tom Page <tompage1994@hotmail.co.uk>
Shrews
Shrews requested changes Apr 2, 2025
View reviewed changes
Tompage1994
Tompage1994 reviewed Apr 2, 2025
View reviewed changes
Tompage1994
Tompage1994 reviewed Apr 2, 2025
View reviewed changes
Copy link
@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damionparry linting hates you

@damionparry @Tompage1994
Update test/integration/test_display_callback improve test
1aafe74 
Co-authored-by: Tom Page <tompage1994@hotmail.co.uk>
Shrews
Shrews approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor
@Shrews Shrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this touches the awx_display callback, we have to get approval from someone on the Controller/AWX team since that is a crucial piece to that project.

@AlanCoding Can you or someone from your team have a look at this? Not sure that it needs full testing, but will leave that up to you.

@Shrews Shrews requested a review from AlanCoding April 2, 2025 15:16
@s-hertel s-hertel removed the needs_triage New item that needs to be triaged label Apr 3, 2025
@Tompage1994
Copy link

Can we get more traction on this again please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tompage1994 Tompage1994 Tompage1994 left review comments

@Shrews Shrews Shrews approved these changes

@AlanCoding AlanCoding Awaiting requested review from AlanCoding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damionparry @Tompage1994 @Shrews @s-hertel
0