-
Notifications
You must be signed in to change notification settings - Fork 372
Add the become flag and become_user var to the callback plugin #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
- Enables propagating the become flag and become user to external logs allowing the use of become to be audited
* Enables propagating the become flag and become user to external logs allowing the use of become to be audited
Signed-off-by: tompage1994@hotmail.co.uk <tpage@redhat.com>
Add callback integration test
@ansible/executor is it possible to get some traction on this PR? It's been awaiting a review for a long time now Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an issue with the tests
Co-authored-by: Tom Page <tompage1994@hotmail.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damionparry linting hates you
Co-authored-by: Tom Page <tompage1994@hotmail.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since this touches the awx_display
callback, we have to get approval from someone on the Controller/AWX team since that is a crucial piece to that project.
@AlanCoding Can you or someone from your team have a look at this? Not sure that it needs full testing, but will leave that up to you.
Can we get more traction on this again please? |