10000 A module for managing ZFS admin privileges by natefoo · Pull Request #19240 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

A module for managing ZFS admin privileges #19240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 23, 2019
Merged

A module for managing ZFS admin privileges #19240

merged 10 commits into from
Jan 23, 2019

Conversation

natefoo
Copy link
Contributor
@natefoo natefoo commented Dec 12, 2016 •
edited
Loading
SUMMARY

This module manages ZFS's administrative privileges.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

zfs_delegate_admin

ANSIBLE VERSION
ansible 2.5.0 (zfs-admin-module 4a6119ce56) last updated 2017/10/24 16:25:41 (GMT -400)
  config file = None
  configured module search path = [u'/home/nate/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/nate/ansible/ansible/lib/ansible
  executable location = /home/nate/ansible/ansible/bin/ansible
  python version = 2.7.13 (default, Jan 19 2017, 14:48:08) [GCC 6.3.0 20170118]
ADDITIONAL INFORMATION

Implements support for the zfs allow and zfs unallow commands, which delegate ZFS administrative privileges (such as the ability to send, recv, or create) on specific ZFS datasets or filesystems to unprivileged users.

@natefoo
Copy link
Contributor Author
natefoo commented Dec 12, 2016

Migrated from ansible/ansible-modules-extras#791

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 module This issue/PR relates to a module. new_plugin This PR includes a new plugin. plugin labels Dec 13, 2016
@xen0l
Copy link
Contributor
xen0l commented Dec 15, 2016 •
edited
Loading

@natefoo you might also be interested in #19181 (and do additional review).

xen0l
xen0l reviewed Dec 15, 2016
View reviewed changes
@xen0l
Copy link
Contributor
xen0l commented Dec 15, 2016

@natefoo you might also want to move this module to storage/zfs, so all ZFS related modules are displayed in its own category in the documentation, which helps a lot when referring to documentation.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 19, 2016
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 2, 2017
@jimi-c jimi-c removed the plugin label Jan 4, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 5, 2017
@ansibot
Copy link
Contributor
ansibot commented Feb 1, 2017

@AugustusKling @rosmo @mcv21 @DavidWittman @mulby @srvg @abulimov @dsummersl @EvanK @goozbach @nibalizer @groks @LinusU @risaacson @dagwieers @dougluce @tmshn @jasperla @saito-hideki @jhoekx @mscherer @matze @maxamillion @davixx @ovcharenko @pyykkis @pmarkham @stygstra @dankeder

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

tmshn
tmshn suggested changes Feb 1, 2017
View reviewed changes
@tmshn
Copy link
Contributor
tmshn commented Feb 1, 2017

I don't know if it's required, but some modules have ANSIBLE_METADATA.
How about adding this?

E.g.;
https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/timezone.py#L31-L33

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 1, 2017
@mscherer mscherer removed the affects_2.3 This issue/PR affects Ansible v2.3 label Nov 24, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 2, 2017
@natefoo
Copy link
Contributor Author
natefoo commented Feb 1, 2018

@dagwieers @Akasurde could you re-review this please?

@natefoo
Catch exceptions when parsing zfs allow output. At least on one
47af601 
version of ZFS (on a 2016 version of illumos) will have a single space
in the user or group column if the name can't be resolved by the
system's name services).
@ansibot ansibot removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 1, 2018
@maxamillion
Copy link
Contributor

@dagwieers @Akasurde re-ping

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 15, 2018
@dagwieers dagwieers added the solaris Solaris community label Jan 18, 2019
@ansibot
Copy link
Contributor
ansibot commented Jan 18, 2019

cc @L2G @brontitall @dermute @scathatheworm @szinck @troy2914
click here for bot help

@ansibot ansibot added cloud zfs ZFS community labels Jan 18, 2019
@dagwieers dagwieers dismissed Akasurde’s stale review January 23, 2019 02:44

All remarks have been dealt with.

@dagwieers
Copy link
Contributor

rebuild_merge

@ansibot
Copy link
Contributor
ansibot commented Jan 23, 2019

cc @bcoca @jpdasma
click here for bot help

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 23, 2019
@dagwieers
Copy link
Contributor

This one has been in the queue for too long, and only minor changes are needed.
I am going to merge this and fix them in a subsequent commit.

@dagwieers dagwieers merged commit 64b5790 into ansible:devel Jan 23, 2019
@mattclay
Copy link
Member

@dagwieers Please don't merge PRs that have not passed tests or are failing tests. If fixes need to be made, they need to be done as part of the PR before merging. If that's not possible, close the original PR and open a new one with the original work plus the necessary fixes.

@gundalow
Copy link
Contributor

Examples need updating to include, - name: and use key: value

@dagwieers
Copy link
Contributor

@gundalow This was done in the subsequent PR. The author did not allow me to add commits to this PR.

@ansible ansible locked and limited conversation to collaborators Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xen0l xen0l xen0l left review comments

@senorsmile senorsmile senorsmile left review comments

@tmshn tmshn tmshn requested changes

@dagwieers dagwieers dagwieers approved these changes

@Akasurde Akasurde Akasurde left review comments

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cloud module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core solaris Solaris community stale_review Updates were made after the last review and the last review is more than 7 days old. storage support:community This issue/PR relates to code supported by the Ansible community. zfs ZFS community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0