8000 add freebsd_update by rusik69 · Pull Request #41976 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add freebsd_update #41976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

add freebsd_update #41976

wants to merge 2 commits into from

Conversation

rusik69
Copy link
Contributor
@rusik69 rusik69 commented Jun 26, 2018 •
edited by bcoca
Loading
SUMMARY

Adding freebsd_update module

This commit is adding freebsd_update module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

freebsd_update


Fixes 41367

@rusik69 rusik69 mentioned this pull request Jun 26, 2018
Closed
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 26, 2018
@ansibot
Copy link
Contributor
ansibot commented Jun 26, 2018

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/system/freebsd_update.py:99:14: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/system/freebsd_update.py:129:21: undefined-variable Undefined variable 'database'
lib/ansible/modules/system/freebsd_update.py:134:32: undefined-variable Undefined variable 'split'

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/freebsd_update.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/freebsd_update.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/freebsd_update.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/freebsd_update.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/freebsd_update.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/system/freebsd_update.py:0:0: E305 DOCUMENTATION.options.action.description.0: expected str @ data['options']['action']['description'][0]. Got {'freebsd-update command to execute': 'fetch, upgrade, install, rollback, IDS, cron.'}
lib/ansible/modules/system/freebsd_update.py:0:0: E312 No RETURN provided
lib/ansible/modules/system/freebsd_update.py:0:0: E324 Value for "default" from the argument_spec (None) for "basedir" does not match the documentation ('/')

click here for bot help

@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Jun 26, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 4, 2018
johnwesley
johnwesley reviewed Jul 14, 2018
View reviewed changes
lib/ansible/modules/system/freebsd_update.py
force = module.params.get('force')
key = module.params.get('key')

freebsd_update_bin = module.get_bin_path('freebsd_update', True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bin on FreeBSD 11.2 is freebsd-update.
Error:
"Failed to find required executable freebsd_update in paths: /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/freebsd/bin"

@dagwieers dagwieers added the bsd BSD community label Jan 18, 2019
@ansibot ansibot added the system System category label Feb 19, 2019
@part1zano part1zano mentioned this pull request Apr 5, 2019
Closed
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 16, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 17, 2019
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor
ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnwesley johnwesley johnwesley left review comments

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bot_closed bsd BSD community ci_verified Changes made in this PR are causing tests to fail. collection:community.general collection Related to Ansible Collections work has_issue module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rusik69 @ansibot @johnwesley @dagwieers @ryansb @mattclay
0