8000 listify_lookup_plugin_terms deprecate dataloader by bcoca · Pull Request #78244 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

listify_lookup_plugin_terms deprecate dataloader #78244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

listify_lookup_plugin_terms deprecate dataloader #78244

merged 2 commits into from
Jul 12, 2022

Conversation

bcoca
Copy link
Member
@bcoca bcoca commented Jul 12, 2022 •
edited
Loading
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

listify_lookup_plugin_terms

@bcoca bcoca changed the title Remove useless loader listify_lookup_plugin_terms deprecate dataloader Jul 12, 2022
@ansibot ansibot added affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 12, 2022
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jul 12, 2022
@bcoca
listify_lookup_plugin_terms deprecate dataloader
bf670f8 
  deprecated useless dataloader pass to function
  also removed from callers in core
@bcoca bcoca force-pushed the remove_useless_loader branch from 41ce05d to bf670f8 Compare July 12, 2022 15:51
s-hertel
s-hertel approved these changes Jul 12, 2022
View reviewed changes
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 12, 2022
@bcoca @s-hertel
Update changelogs/fragments/loader_in_listify.yml
defb7db 
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 12, 2022
@bcoca bcoca merged commit 1f59bbf into ansible:devel Jul 12, 2022
@bcoca bcoca deleted the remove_useless_loader branch July 12, 2022 20:10
@ansible ansible locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcoca @s-hertel @mkrizek @ansibot
0