8000 Templating overhaul, implement Data Tagging by nitzmahone · Pull Request #84621 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Templating overhaul, implement Data Tagging #84621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Templating overhaul, implement Data Tagging #84621

merged 2 commits into from
Apr 14, 2025

Conversation

nitzmahone
Copy link
Member
@nitzmahone nitzmahone commented Jan 28, 2025 •
edited by bcoca
Loading

Links to documentation, detailed discussion and instructions for testing can be found on the Ansible forum.

Data Tagging

  • Variables and values can now carry extensible metadata tags, including provenance, template trust status, and deprecation information.
  • Values tagged as Deprecated can issue runtime warnings when accessed.

Development and integration of the Data Tagging features led to the discovery of many latent security and performance issues in other parts of ansible-core, culminating in an overhaul of the templating engine and other areas:

Templating

  • String values now require explicit trust to be rendered as templates.
  • Rewrote Jinja integration.
  • Most nested/recursive templating operations are now fully lazy, vastly improving performance in complex scenarios.

Error handling

  • Standardized error handling and exception capture throughout controller and target Python code.
  • Automatically provide detailed error messages with operation and source context.
  • Removed many bespoke error handlers that actually masked detail.
  • Traceback capture/display is no longer tied to verbosity, and can be optionally triggered at the site of any exception, warning, or error.

Test coverage

  • Increased coverage, quality, and stability of integration and unit tests for numerous core features.
ISSUE TYPE
  • Feature Pull Request
ADDITIONAL INFO

Draft porting guide ansible/ansible-documentation#2429

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. networking Network category labels Jan 28, 2025
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jan 28, 2025
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 28, 2025
@ansibot

This comment was marked as resolved.

Sign in to view
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jan 28, 2025
@sivel sivel mentioned this pull request Jan 28, 2025
Closed
1 task
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 28, 2025
@ansibot

This comment was marked as resolved.

Sign in to view
@ansible ansible locked and limited conversation to collaborators Jan 28, 2025
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 28, 2025
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 31, 2025
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Jan 31, 2025
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 31, 2025
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 1, 2025
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 1, 2025
bcoca
bcoca reviewed Feb 4, 2025
View reviewed changes
bcoca
bcoca reviewed Feb 4, 2025
View reviewed changes
@ansibot

This comment was marked as resolved.

Sign in to view
11 similar comments
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
@mattclay mattclay added the bot_broken The bot is misbehaving. NOT for failing CI. A staff member will investigate. label Apr 9, 2025
@mattclay

This comment was marked as resolved.

Sign in to view
@mattclay mattclay removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 9, 2025
@mkrizek mkrizek removed the bot_broken The bot is misbehaving. NOT for failing CI. A staff member will investigate. label Apr 9, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 11, 2025
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 11, 2025
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Apr 11, 2025
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 11, 2025
@nitzmahone @mattclay
Overhaul templating impl, add data tagging
29fffa0 
Co-authored-by: Matt Davis <mrd@redhat.com>
Co-authored-by: Matt Clay <matt@mystile.com>
@nitzmahone nitzmahone marked this pull request as ready for review April 12, 2025 01:23
@mattclay mattclay changed the title [WIP] Templating overhaul, implement Data Tagging Templating overhaul, implement Data Tagging Apr 12, 2025
@webknjaz
Copy link
Member

/azp run

@mattclay mattclay merged commit 35750ed into ansible:devel Apr 14, 2025
74 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz left review comments

@Akasurde Akasurde Akasurde left review comments

@mattclay mattclay mattclay left review comments

@bcoca bcoca bcoca left review comments

@sivel sivel sivel approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nitzmahone @ansibot @webknjaz @mattclay @sivel @Akasurde @bcoca @mkrizek
0