8000 AAP-40838: creates policy as code assemblies and modules by hherbly · Pull Request #3434 · ansible/aap-docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

AAP-40838: creates policy as code assemblies and modules #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 9, 2025
Merged

AAP-40838: creates policy as code assemblies and modules #3434

merged 9 commits into from
May 9, 2025

Conversation

hherbly
Copy link
Contributor
@hherbly hherbly commented May 8, 2025

This PR creates the assembly and modules for the policy as code documentation. See AAP-40838 for more.

@hherbly hherbly added Draft Draft / work in progress: do not merge Not ready for peer review This PR is under construction and not ready for peer review Controller Content applies to automation controller 2.5 Content applies to AAP 2.5 Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels May 8, 2025
@hherbly hherbly removed Draft Draft / work in progress: do not merge Not ready for peer review This PR is under construction and not ready for peer review labels May 9, 2025
dcdacosta
dcdacosta approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor
@dcdacosta dcdacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a number of comments to fix things but there's nothing glaring here to prevent us from publishing and fixing later.

dcdacosta
dcdacosta reviewed May 9, 2025
View reviewed changes
downstream/assemblies/platform/assembly-controller-pac.adoc

== Prerequisites

Before you can implement policy enforcement in your Ansible instance, you must have:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "your Ansible Automation Platform instance", or to simplify your "platform instance"?

dcdacosta
dcdacosta reviewed May 9, 2025
View reviewed changes
downstream/modules/platform/proc-pac-add-policy-to-inventory.adoc
.Procedure

. From the navigation panel, select {MenuInfrastructureInventories}.
. On the Inventories screen:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing to "Inventories page" for consistency.

dcdacosta
dcdacosta reviewed May 9, 2025
View reviewed changes
downstream/modules/platform/proc-pac-add-policy-to-org.adoc
.Procedure

. From the navigation panel, select {MenuAMOrganizations}.
. On the Organizations screen:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing to "Organizations page" for consistency.

dcdacosta
dcdacosta reviewed May 9, 2025
View reviewed changes
downstream/modules/platform/proc-pac-add-policy-to-template.adoc

. From the navigation panel, select {MenuAETemplates}.
. On the Automation Templates screen:
.. To edit an existing job template, find the job template you want to edit and click the pencil icon image:leftpencil.png[Edit,15,15] to go to the editing screen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing this to "Edit page"

dcdacosta
dcdacosta reviewed May 9, 2025
View reviewed changes
downstream/modules/platform/proc-pac-add-policy-to-org.adoc

. From the navigation panel, select {MenuAMOrganizations}.
. On the Organizations screen:
.. To edit an existing organization, find the organization you want to edit and click the pencil icon image:leftpencil.png[Edit,15,15] to go to the editing screen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing this to "Edit page"

dcdacosta
dcdacosta reviewed May 9, 2025
View reviewed changes
downstream/modules/platform/proc-pac-add-policy-to-inventory.adoc

. From the navigation panel, select {MenuInfrastructureInventories}.
. On the Inventories screen:
.. To edit an existing inventory, find the inventory you want to edit and click the pencil icon image:leftpencil.png[Edit,15,15] to go to the editing screen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing this to "Edit page"

dcdacosta
dcdacosta approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor
@dcdacosta dcdacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions, otherwise LGTM! Merging for fixes to be implemented in a separate PR.

@dcdacosta dcdacosta merged commit 8db327d into ansible:main May 9, 2025
hherbly added a commit to hherbly/aap-docs that referenced this pull request May 9, 2025
@hherbly
AAP-40838: creates policy as code assemblies and modules (ansible#3434)
5ece601 
* creates policy as code assemblies and modules

* updates master.adoc with new assembly

* populates enable pac module

* populates configure pac settings module

* populates enforcement points module

* creates new concept module about policy structure

* commenting out table for now

* adds and populates three new proc mods

* implements peer review feedback
dcdacosta pushed a commit that referenced this pull request May 9, 2025
@hherbly
AAP-40838: creates policy as code assemblies and modules (#3434) (#3442)
e8c0ad6 
* creates policy as code assemblies and modules

* updates master.adoc with new assembly

* populates enable pac module

* populates configure pac settings module

* populates enforcement points module

* creates new concept module about policy structure

* commenting out table for now

* adds and populates three new proc mods

* implements peer review feedback
@hherbly hherbly added Backports confirmed Backports to release branches have been verified Backported to 2.5 Changes have been applied to the AAP 2.5 branch and removed Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcdacosta dcdacosta dcdacosta approved these changes

Assignees
No one assigned
Labels
2.5 Content applies to AAP 2.5 Backported to 2.5 Changes have been applied to the AAP 2.5 branch Backports confirmed Backports to release branches have been verified Controller Content applies to automation controller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hherbly @dcdacosta
0